Skip to content

refactor(mosaic): Clean up shared screens between sign-up + sign-in - #10823

Open
austincalvelage wants to merge 5 commits into
austin/mosaic-sign-up-gapsfrom
austin/mosaic-auth-flow-shared
Open

austincalvelage wants to merge 5 commits into
austin/mosaic-sign-up-gapsfrom
austin/mosaic-auth-flow-shared

Conversation

@austincalvelage

@austincalvelage austincalvelage commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Description

Sign-in and sign-up show a lot of the same screens. This PR puts those screens in one shared place, blocks/auth, and tidies up what was duplicated around them. Nothing changes for users: the screens look and read the same.

What moved

  • The ten screens both flows use now live in blocks/auth: the email link screens, the wallet and enterprise pickers, the alternative phone screen, the loading, protect-check and blocked notices, the identity line and the captcha.
  • Each one is handed its text by the flow that shows it, the same way the blocks/verification screens work.

Sign-up has its own text now

  • Sign-up used to borrow strings from sign-in. It now has its own copies in sign-up.messages.ts, with the same English, so a customer can change sign-up's wording without changing sign-in's.
  • No sign-in string was renamed or removed.
  • The Continue button is signUp.submit, because signUp.continue was already taken by the "continue" step's title.

Duplicates removed

  • Sign-in's passkey screen was a copy of VerificationPasskey, so sign-in uses that one now. It gained a slot for the email line with the edit button.
  • The Resend link and its countdown were written out three times, in sign-in, sign-up and reverification. All three now call one verificationResend helper.
  • CodeStep is gone. It only passed things through to VerificationCode, so both flows render that directly.

Where the leftovers went

  • The helpers that pick a screen's text moved out of sign-in.view.tsx into sign-in.utils.ts, and sign-up has its own small set. Their tests moved with them.
  • Sign-in and sign-up each keep their own small layout styles. A few are the same in both; that is on purpose, so neither flow reaches into the other's or the block's styles.
  • features/auth-flow is down to two small files both flows need: the form values type and the phone number formatter.

Follows #10822. This is the last PR of the sign-in and sign-up view stack.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 16, 2026 7:08am UTC
swingset Ready Ready Preview Nov 16, 2026 7:08am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 992a5bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@austincalvelage
austincalvelage marked this pull request as ready for review November 14, 2026 00:08
@austincalvelage austincalvelage changed the title refactor(mosaic): move the screens sign-in and sign-up share into features/auth-flow refactor(mosaic): Clean up shared screens between sign-up + sign-in Nov 14, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Matches Sign-in and sign-up screens unchanged

All 119 SignIn and SignUp examples, including the divider and name row the moved styles draw, show the same text. 117 are pixel-identical, and the other 2 differ only in the captcha widget, which also varies between runs of one commit.

All examples compared

Merge-base

Sign-up divider and name row

This PR 992a5bf9

Sign-up divider and name row

Also checked · 4 match

Matches Sign-up copy for unstoried states
Matches Code step works without CodeStep
Matches Reverification screens unchanged
Matches Passkey step via VerificationPasskey

Proof on 992a5bf9 (from 94996502) · Did Proof get it right? Yes · No

View full Proof report · React 👎 or comment @codesmith dismiss this proof to dismiss

…cks/auth

The shared screens take their copy as a messages prop, like the
verification blocks, so sign-up reads only its own messages. Sign-up
gains the keys it used to borrow from sign-in, with the same English.

The code step copy helpers that only sign-in uses move back to
sign-in.utils.ts, and sign-up gets its own.
… verification blocks

Sign-in renders VerificationPasskey, which takes the identity line as a
slot like VerificationCode does. The sign-in, sign-up and reverification
views build the Resend link through one verificationResend helper.

The choice step copy moves to sign-in.utils.ts, and sign-in and sign-up
declare the style atoms their own steps use.
…ature

The divider, captcha spotlight and name row atoms style markup that only
the sign-in and sign-up steps draw, so each feature declares its own and
auth-flow.styles.ts is removed.

This branch was successfully deployed

2 active deployments
Preview – swingset — 992a5bf9 Deployed Nov 16, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 992a5bf9 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant